Skip to content

Fixes reference leak#3457

Merged
zooba merged 1 commit into
python:masterfrom
zooba:findvs-refleak
Sep 8, 2017
Merged

Fixes reference leak#3457
zooba merged 1 commit into
python:masterfrom
zooba:findvs-refleak

Conversation

@zooba

@zooba zooba commented Sep 8, 2017

Copy link
Copy Markdown
Member

Turns out, PyTuple_Pack adds a reference to everything it packs... who knew?!

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@zooba zooba merged commit af8d6b9 into python:master Sep 8, 2017
@miss-islington

Copy link
Copy Markdown
Contributor

🐍🍒⛏🤖 Thanks @zooba for the PR, and @zooba for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 8, 2017
@bedevere-bot

Copy link
Copy Markdown

GH-3460 is a backport of this pull request to the 3.6 branch.

@zooba zooba deleted the findvs-refleak branch September 8, 2017 18:38
zooba pushed a commit that referenced this pull request Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants